Scale dependency being ignored on TextSymbolizer

[jnewmoyer]

Bug

Describe the bug
Converting from SLD to OpenLayers style, my labels are showing at all zoom levels, even though the SLD uses a max scale denominator.

To Reproduce
Steps to reproduce the behavior:

1. Create an SLD with a label style and max scale denom
2. Convert the style to geostyler and then to OpenLayers
3. Style a vector layer with the OL style.

Expected behavior
the labels appear only at scales inside of 1:5M.

Desktop (please complete the following information):

• OS: Windows
• Browser: Chrome
• Version: 91.x

Additional context

The geostyler rule after converted:

{
      "name": "Labels",
      "scaleDenominator": {
        "max": 5000000
      },
      "symbolizers": [
        {
          "kind": "Text",
          "label": "{{title}}",
          "color": "#ffffff",
          "haloWidth": 1,
          "haloColor": "#000000",
          "offset": [
            0,
            10
          ],
          "size": 19,
          "font": [
            "SansSerif.bold"
          ],
          "fontStyle": "normal",
          "fontWeight": "bold"
        }
      ]
    }

[jansule]

Thanks for the info @jnewmoyer.

Which projection are you using on your map client?

[jnewmoyer]

EPSG:4326

[jansule]

Could you check if it works for you in EPSG:3857?

EPSG:4326 uses degrees as units. Currently, geostyler-openlayers-parser assumes metric units (https://github.com/geostyler/geostyler-openlayers-parser/blob/master/src/OlStyleParser.ts#L537). Adding a switch 'm' / 'degrees' for the second argument there might solve your problem.

Would you like to create a PR for that?

[jnewmoyer]

Absolutely. Stand by...

[KaiVolland]

Seems like you could fix the issue @jnewmoyer. If not please reply or reopen.

[jnewmoyer]

Apologies for never getting to the PR. I don't believe this is fixed though. It seems like scale is always evaluated with Meters in mind:

geostyler-openlayers-parser/src/OlStyleParser.ts

Line 772 in 78c9ee3

const mpu = METERS_PER_UNIT.m;

[KaiVolland]

Ok. Thanks for keeping this alive. I was just in tabula rasa mode. 😄