New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the XSHG calendar further into the future #276

Open

hannes101 opened this issue Jan 5, 2023 · 1 comment

hannes101 commented Jan 5, 2023

The calendar for XSHG ends in 2025, which is not that far in the future any more. Is there some code somewhere to compute the holidays on the Shanghai stock exchange? As far as I can see they are all hard-coded in https://github.com/gerrymanoim/exchange_calendars/blob/master/exchange_calendars/exchange_calendar_xshg.py

I could of course try to find all the holidays for any later dates, but it probably would be a bit easier if someone has some more "local" knowledge.

hannes101 changed the title ~~Extend the XSHG calendar more time into the future~~ Extend the XSHG calendar further into the future

Collaborator

maread99 commented Jan 9, 2023

Hi @hannes101, yup they are hard-coded.

I suspect the holiday rules are sufficiently complex that it was decided it would be simpler to just hard code them each year.

PR's welcome to extend the holidays (Workflow to modify an existing Exchange Calendar)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment