Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get() with index should allow indexes with multiple fields #7

Closed
xixixao opened this issue Jan 13, 2024 · 2 comments
Closed

get() with index should allow indexes with multiple fields #7

xixixao opened this issue Jan 13, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@xixixao
Copy link
Collaborator

xixixao commented Jan 13, 2024

It should be possible to use a compound index to query unique ents:

ctx.table("users").get("firstNameLastName", firstName, lastName)

I had trouble getting the types to oblige when I was implementing get() with indexes.

@xixixao xixixao added the bug Something isn't working label Jan 13, 2024
@xixixao
Copy link
Collaborator Author

xixixao commented Jan 29, 2024

This is blocked by microsoft/TypeScript#29919 (which should be fixed soon)

@xixixao
Copy link
Collaborator Author

xixixao commented Feb 27, 2024

This is fixed on https://github.com/xixixao/convex-ents/tree/variadic-get, will wait for VS Code release with TS 5.4

@xixixao xixixao closed this as completed in 614bb98 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant