Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collaborative revert still uses the channel_manager which it shouldn't #1546

Closed
bonomat opened this issue Nov 1, 2023 · 2 comments · Fixed by #1607
Closed

Collaborative revert still uses the channel_manager which it shouldn't #1546

bonomat opened this issue Nov 1, 2023 · 2 comments · Fixed by #1607
Assignees
@luckysori

Comments

@bonomat
Copy link
Contributor

bonomat commented Nov 1, 2023

See here:

10101/coordinator/src/collaborative_revert.rs

Lines 49 to 52 in 1f28dcc

.channel_manager
.get_channel_details(&channel_id)
.context("Could not get channel")?;

@bonomat
Copy link
Contributor Author

bonomat commented Nov 1, 2023

Let's follow-up on this once #1482 is in.

@bonomat
Copy link
Contributor Author

bonomat commented Nov 1, 2023

When doing this ticket we should tackle: 32a9226#r1379242880

@bonomat bonomat mentioned this issue Nov 1, 2023
Merged
@holzeis holzeis assigned luckysori and unassigned luckysori Nov 13, 2023
@luckysori luckysori self-assigned this Nov 16, 2023
@luckysori luckysori mentioned this issue Nov 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luckysori luckysori

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce collaborative revert reliance on ChannelManager get10101/10101
2 participants
@bonomat @luckysori