Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position margin disagrees with close margin after clicking Close Position button #2577

Closed
luckysori opened this issue May 29, 2024 · 2 comments · Fixed by #2624
Closed

Position margin disagrees with close margin after clicking Close Position button #2577

luckysori opened this issue May 29, 2024 · 2 comments · Fixed by #2624
Assignees
Labels
bug Something isn't working mobile UI

Comments

@luckysori
Copy link
Contributor

image

Repro

  • Open $100 long position with e.g. 5,000 sats margin.
  • Press Close Position button.
  • The margin row will show a margin that does not match 5,000 sats. Instead, it will be equivalent to the margin for opening a new $100 short position, which is different because the bid and ask prices are normally different.

Interestingly, this is fixed if you toy around with resizing the position first. Although we then display Margin 0 sats:

image

It would make sense to not display the margin row when closing positions.

@luckysori luckysori added bug Something isn't working mobile UI labels May 29, 2024
@holzeis holzeis self-assigned this May 29, 2024
@Restioson
Copy link
Contributor

@holzeis: if you'd like I can take it over?

I would implement it by not showing the margin as @luckysori suggested, as it seems the simplest option (unless we have a reason to show the margin)

@holzeis
Copy link
Contributor

holzeis commented Jun 5, 2024

Go for it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mobile UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants