Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clouds not showing in onboarding any more (only when system appearance = light mode) #221

Closed
rolznz opened this issue Jul 5, 2024 · 3 comments · Fixed by #244 or #251
Closed

Clouds not showing in onboarding any more (only when system appearance = light mode) #221

rolznz opened this issue Jul 5, 2024 · 3 comments · Fixed by #244 or #251
Assignees
@reneaaron

Comments

@rolznz
Copy link
Contributor

rolznz commented Jul 5, 2024

to reproduce, delete your cookies/local storage and set system appearance to lightmode. Then go through the onboarding.
@bumi
Copy link
Contributor

bumi commented Jul 8, 2024

this also broke?
CleanShot 2024-07-08 at 10 01 14@2x

@bumi
Copy link
Contributor

bumi commented Jul 8, 2024

I think the default theme is not chosen

@rolznz
Copy link
Contributor Author

rolznz commented Jul 9, 2024

Jakub said he'd be ok if we can find a way to force the app to use dark mode just on the onboarding pages

@reneaaron reneaaron mentioned this issue Jul 10, 2024
Merged
@reneaaron reneaaron reopened this Jul 10, 2024
@rolznz rolznz mentioned this issue Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reneaaron reneaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: validate theme from storage getAlby/hub
fix: force dark mode in intro getAlby/hub
3 participants
@bumi @rolznz @reneaaron