New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement versioning and NIP-44 support #737

Open

rolznz opened this issue Oct 16, 2024 · 1 comment

Labels

ready for implementation

Milestone

Contributor

rolznz commented Oct 16, 2024

See nostr-protocol/nips#1531

Notes:

Alby Hub should indicate support for 1.0 and 0.0, and maintain support for 0.0 for the unforeseen future.
This should be implemented in the Alby JS SDK (and therefore at least Alby Go + Alby Extension) to ensure the full flow is working.
See how NIP-47 notifications fits in with versioning.
Add unit tests to ensure we maintain support for both versions and return the correct error code for unsupported versions.

rolznz added the needs planning label

Contributor Author

rolznz commented Oct 16, 2024

@bumi @im-adithya any thoughts?

rolznz mentioned this issue

Implement support for NWC version 1.0 getAlby/js-sdk#263

Open

rolznz added this to the v1.11.0 milestone

rolznz added ready for implementation and removed needs planning labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment