Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check date for payment and invoice requests and ignore old requests #814

Closed
bumi opened this issue Nov 20, 2024 · 0 comments · Fixed by #837
Closed

Check date for payment and invoice requests and ignore old requests #814

bumi opened this issue Nov 20, 2024 · 0 comments · Fixed by #837
Assignees
@rolznz
Milestone
v1.11.0

Comments

@bumi
Copy link
Contributor

bumi commented Nov 20, 2024

The relay could forward old requests. Which is fine and actually also intended as it makes sure we can respond even after a downtime or network issue.

But we should check the creation date of a request and ignore too old requests for payments and invoice creation.

I would suggest we ignore requests that are older than 6h (random number) maybe?
@rolznz rolznz added this to the v1.11.0 milestone Nov 20, 2024
@rolznz rolznz self-assigned this Nov 21, 2024
@rolznz rolznz mentioned this issue Nov 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolznz rolznz

Labels
None yet
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging a pull request may close this issue.

fix: ignore old payment and invoice requests getAlby/hub
2 participants
@bumi @rolznz