Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getdns_extension_set_libuv_loop not exported in v1.6.0 #493

Open
certxlm opened this issue Oct 30, 2020 · 4 comments
Open

getdns_extension_set_libuv_loop not exported in v1.6.0 #493

certxlm opened this issue Oct 30, 2020 · 4 comments

Comments

@certxlm
Copy link

certxlm commented Oct 30, 2020

Hi there,
We're working on our own little piece of C code involving the UV event loop and getdns.
In v1.5.2, building getdns with libtoolize -ci; autoreconf -fi; ./configure --with-libuv; make produces a shared library with the getdns_extension_set_libuv_loop symbol exported.
In v1.6.0, cmake -DBUILD_LIBUV=ON .; make produces a shared library without getdns_extension_set_libuv_loop. Needless to say that after compiling our usual code (with -lgetdns_ex_uv, why the change of name by the way?), we get an (un)expected undefined reference for getdns_extension_set_libuv_loop.

Did we miss something while building the library? Thanks for any help you could provide!
Ps: system is a fresh install of Ubuntu 18.04 LTS.

% git branch; nm -D ./src/.libs/libgetdns_ext_uv.so

* (HEAD detached at v1.5.2)
  develop
                 U __assert_fail
                 w __cxa_finalize
                 U getdns_context_set_eventloop
0000000000000dc0 T getdns_extension_set_libuv_loop
                 w __gmon_start__
                 w _ITM_deregisterTMCloneTable
                 w _ITM_registerTMCloneTable

% git branch; nm -D libgetdns_ex_uv.so

* (HEAD detached at v1.6.0)
  develop
                 U __assert_fail
                 w __cxa_finalize
                 U getdns_context_set_eventloop
                 w __gmon_start__
                 w _ITM_deregisterTMCloneTable
                 w _ITM_registerTMCloneTable
                 U plain_mem_funcs_user_arg
                 U priv_getdns_context_mf
@wtoorop
Copy link
Contributor

wtoorop commented Nov 2, 2020

Hi @certxlm I believe this is a mistake that happened when moving to cmake (also the name change).
@banburybill could you have a look? Thanks!

@banburybill
Copy link
Contributor

@wtoorop Looks like the library name change is an issue for all extension libraries. Shall we change them all back from getdns_ex_* to getdns_ext_*?

@wtoorop
Copy link
Contributor

wtoorop commented Nov 4, 2020

@banburybill I'm not sure... if we do, we should make it another "major" release (so going to 1.7).
What do you think?

@certxlm
Copy link
Author

certxlm commented Dec 23, 2020

Hello,
Just wanted to confirm that the lastest PR fixes name and symbol issues, thanks!
Regards,
CERT-XLM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants