Regression "woocommerce-order-items" postbox gets hidden when "dokan_commission_box" is hidden

[oliviertassinari]

Bug Description

This logic can't work:

dokan/templates/orders/commission-meta-box-html.php

Line 42 in 8e3b23a

<div id="woocommerce-order-items" class="postbox" style='border: none'>

WordPress hides blocks using this logic:

hidden = $( '.postbox' ).filter( ':hidden' ).map( function() { return this.id; } ).get().join( ',' );

Souce: https://github.com/WordPress/WordPress/blob/aa87f886780f31edc1f9148ed16cf36046d7f9bf/wp-admin/js/postbox.js#L462

And because :hidden match is broad: https://api.jquery.com/hidden-selector/

An ancestor element is hidden, so the element is not shown on the page

it means that hiding "dokan_commission_box" also sets "woocommerce-order-items" as hidden

See the structure of the DOM:

Screen.Recording.2025-01-05.at.16.42.53.mov

It gets even worse, because there are two woocommerce-order-items on the page, once one is hidden and the page is released, the logic sets the two as hidden, and it's impossible to show back without sending custom cURL requests or updating the database: https://wordpress.org/support/topic/edit-order-product-details-no-longer-possible/#post-18226349

Step To Reproduce

Screen.Recording.2025-01-05.at.16.46.24.mov

Additional Information

There has been a lot of regressions lately:

• Unsupported operand types at dokan-lite/includes/Commission/Settings/OrderItem.php:74 #2491
• Unsupported operand types at dokan-lite/includes/Commission.php:267 #2486
• wrong migration logic https://app.dokan.co/support/94902
• wrong migration logic https://app.dokan.co/support/94076

and now this one. Please do something about it, we can't sustain this pace.

Environment (please complete the following information)

1. Dokan Version: v3.14.4

cc @hasdfa for awareness, in case someone complains about this bug internally.

[TanvirHasan19]

Hi @oliviertassinari

The issue you are experiencing appears to be site-specific, as we are unable to replicate it on our local environments. We recommend reaching out through our official support channel by creating a support ticket from your Dokan.co account or submitting the form on our "Contact Us" page.

Thank you!

[oliviertassinari]

we are unable to replicate it on our local environments

@TanvirHasan19 We have another user complaining: https://wordpress.org/support/topic/edit-order-product-details-no-longer-possible/.

I could reproduce the problem on a from-scratch installation on http://dokan-bug-2499.infy.uk/?i=1 (I can provide the credentials if needed). The reproduction steps are:

1. Open a product page. (In my case http://dokan-bug-2499.infy.uk/wp-admin/admin.php?page=wc-orders&action=edit&id=28)
2. Close the "Commissions" box
3. Reload the page
4. At this stage, people are screwed, they can never see the order items again.

To restore the box visibility, there are a few ways possible that I have worked (from the UI down to the backend):

1. Find the hidden element jQuery( '.postbox' ).filter( ':hidden' ) in the console, remove the hidden class name, toggle the commission box to be open, and reload.
2. cURL

curl 'http://dokan-bug-2499.infy.uk/wp-admin/admin-ajax.php' \
  -H 'Accept: */*' \
  -H 'Accept-Language: en-US,en;q=0.9,fr-FR;q=0.8,fr;q=0.7,he;q=0.6,bg;q=0.5,gu;q=0.4' \
  -H 'Cache-Control: no-cache' \
  -H 'Connection: keep-alive' \
  -H 'Content-Type: application/x-www-form-urlencoded; charset=UTF-8' \
  -H 'Cookie: 
  -H 'Origin: http://dokan-bug-2499.infy.uk' \
  -H 'Pragma: no-cache' \
  -H 'Referer: http://dokan-bug-2499.infy.uk/wp-admin/admin.php?page=wc-orders&action=edit&id=28' \
  -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36' \
  -H 'X-Requested-With: XMLHttpRequest' \
  --data-raw 'action=closed-postboxes&closed=&hidden=&closedpostboxesnonce=9b3f6a8bbe&page=woocommerce_page_wc-orders' \
  --insecure

3. Delete the meta_key="meta-box-order_shop_order" row under in the _usermeta MySQL table fixed the issue.