Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] missing appdmg dependency #42

Closed
remyleone opened this issue Dec 26, 2022 · 2 comments
Closed

[BUG] missing appdmg dependency #42

remyleone opened this issue Dec 26, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@remyleone
Copy link

remyleone commented Dec 26, 2022

Describe the bug

The npm run make command fails with a missing dependency.

To Reproduce

$ npm run make

> ezy@1.0.0-beta.14 make
> electron-forge make

✔ Checking your system
⠋ Loading configuration
✔ Loading configuration
✔ Resolving make targets
  › Making for the following targets: dmg
✔ Running package command
  ✔ Preparing to package application
  ✔ Running packaging hooks
    ✔ Running generateAssets hook
    ✔ Running prePackage hook
      ✔ [plugin-webpack] Preparing native dependencies
      ✔ [plugin-webpack] Building webpack bundles
  ✔ Packaging application
    ✔ Packaging for x64 on darwin [4s]
  ✔ Running postPackage hook
✔ Running preMake hook
❯ Making distributables
  ✖ Making a dmg distributable for darwin/x64
    › Cannot find module 'appdmg'
      Require stack:
      - /Users/sieben/workspace/upstream/ezy/node_modules/electron-installer-dmg/src/index.js
      - /Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/maker-dmg/dist/MakerDMG.js
      - /Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/core/dist/util/require-search.js
      - /Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/core/dist/util/plugin-interface.js
      - /Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/core/dist/util/forge-config.js
      - /Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/core/dist/util/index.js
      - /Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/core/dist/api/index.js
      - /Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/cli/dist/electron-forge-make.js
◼ Running postMake hook

An unhandled rejection has occurred inside Forge:
Error: Cannot find module 'appdmg'
Require stack:
- /Users/sieben/workspace/upstream/ezy/node_modules/electron-installer-dmg/src/index.js
- /Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/maker-dmg/dist/MakerDMG.js
- /Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/core/dist/util/require-search.js
- /Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/core/dist/util/plugin-interface.js
- /Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/core/dist/util/forge-config.js
- /Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/core/dist/util/index.js
- /Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/core/dist/api/index.js
- /Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/cli/dist/electron-forge-make.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1039:15)
    at Module._load (node:internal/modules/cjs/loader:885:27)
    at Module.require (node:internal/modules/cjs/loader:1105:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at build (/Users/sieben/workspace/upstream/ezy/node_modules/electron-installer-dmg/src/index.js:9:18)
    at module.exports (/Users/sieben/workspace/upstream/ezy/node_modules/electron-installer-dmg/src/index.js:122:10)
    at async MakerDMG.make (/Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/maker-dmg/dist/MakerDMG.js:31:22)
    at async Task.task (/Users/sieben/workspace/upstream/ezy/node_modules/@electron-forge/core/dist/api/make.js:197:55)
    at async Task.run (/Users/sieben/workspace/upstream/ezy/node_modules/listr2/dist/index.cjs:978:11)
    at async /Users/sieben/workspace/upstream/ezy/node_modules/listr2/node_modules/p-map/index.js:57:22

Expected behavior

I expect ezy to build.

Environment

  • OS: macOS 13.1
  • ezy master branch

Additional context
Add any other context about the problem here.

@remyleone remyleone added the bug Something isn't working label Dec 26, 2022
@notmedia
Copy link
Contributor

notmedia commented Dec 27, 2022

@remyleone Hi! Thank you for opening this issue!
How did you install project dependencies?
Try to remove them rm -rf node_modules, install them again via npm ci and then run npm run make

Right now on my local machine I have different error in make while copying

cp -R .../ezy/out/ezy-darwin-x64/ezy.app /Volumes/ezy/ezy.app
cp: /Volumes/ezy/ezy.app: Operation not permitted

Trying to find the solution and I will check the CI that it passing this step.

@notmedia
Copy link
Contributor

notmedia commented Jan 3, 2023

Will be fixed in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants