Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo tagging to use it as submodule #25

Open
nvborisenko opened this issue Feb 26, 2020 · 4 comments
Open

Repo tagging to use it as submodule #25

nvborisenko opened this issue Feb 26, 2020 · 4 comments
Assignees

Comments

@nvborisenko
Copy link

This repo is shared across gauge runner and plugins. All of them are using it as git submoule. The issue is that there is a chance that runners and plugins will use different revisions/commits of proto messages which produces compatibility issues.

I propose to create a specific tag/branch, and all consumers will point submodule to this specific tag/branch.

@sriv
Copy link
Member

sriv commented Feb 26, 2020

Ideally, the gauge-proto definitions should be backward compatible. But this is a good thing to do irrespective.

@sriv sriv self-assigned this Sep 7, 2020
@sriv
Copy link
Member

sriv commented Sep 7, 2020

@nvborisenko - currently, we publish java client for proto changes here: https://mvnrepository.com/artifact/com.thoughtworks.gauge/gauge-api-client

I am considering following tags for matching the same version. Wanted to check with you, if you have any thoughts/suggestions.

We have a nuget package which wraps the C# code, but that is not automated (yet). If you think it would be better to push C# client as well, let me know. We built the C# client for internal use, but I see no reason to keep it that way if it can help other plugin authors.

@zabil
Copy link
Member

zabil commented Jun 27, 2024

Let's discuss this again.

Since we started, there have been many updates in the
protobuf and grpc tools space.

I think we can use https://buf.build/product/bsr and
https://buf.build/product/cli to solve our problem.

Buf has a free option for publishing proto files. So, we
would need to publish our proto files to a registry using this tool,
and then refer to the registry instead of using a git submodule.

Should we consider doing this?

@sriv
Copy link
Member

sriv commented Jun 29, 2024

yes, think this is a good step to take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants