Why highlightOnAction is of String type?

[lufton]

It's confusing, but setConfig method expects highlightOnAction option to be a string (one of 'true' or 'false'). What is the reason for that? Why don't just use boolean?

[zabil]

Taiko is written in javascript and the actual implementation reads the TAIKO_HIGHLIGHT_ON_ACTION variable so it ended up using a string to avoid parsing to boolean.

But the right way is to represent it as a boolean. Please feel free to send a pull request if you a fix in mind, preferably one that is backward compatible works for both string and boolean.

[lufton]

Already: #2584
But it can't be backward compatible because of this code:

taiko/lib/config.js

Lines 31 to 37 in 8b2bb16

	if (typeof defaultConfig[key] !== typeof options[key]) {
	throw new Error(
	`Invalid value for ${key}. Expected ${typeof defaultConfig[
	key
	]} received ${typeof options[key]}`,
	);
	}