Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Frontmatter deleted in Expert Mode #1354

Closed
cniweb opened this issue Feb 25, 2018 · 20 comments
Closed

All Frontmatter deleted in Expert Mode #1354

cniweb opened this issue Feb 25, 2018 · 20 comments
Labels

Comments

@cniweb
Copy link

cniweb commented Feb 25, 2018

With the Grav v1.3.10 and Admin v1.6.7, I have the follwing problem:

Whenever I save a page in Export mode, all Frontmatter (including title etc.) is deleted and replaced with

media_order: ''

Has been reported before: #1252

@RobLui
Copy link
Contributor

RobLui commented Feb 25, 2018

I've had the same issue when i turned edit mode to expert in the admin , when you turn it off and just go to the page itself and edit in expert mode over there, it works just fine for me, might be the same thing for you

@cniweb
Copy link
Author

cniweb commented Feb 25, 2018

Thanks for the tip, it helps. But that's just a workaround.

@RobLui
Copy link
Contributor

RobLui commented Feb 25, 2018

Yeah, it needs a fixo defo :)

@rhukster
Copy link
Member

To confirm, this only happens when the 'default' mode as set in the admin options is set to "expert"? And it works fine when you leave the normal mode, but switch to expert on the page?

@rhukster rhukster added the bug label Feb 25, 2018
@RobLui
Copy link
Contributor

RobLui commented Feb 25, 2018

Confirm - in my case @rhukster

@cniweb
Copy link
Author

cniweb commented Mar 6, 2018

This only happens when the default mode in Admin Options is set to "Expert".

@rhukster
Copy link
Member

rhukster commented Mar 7, 2018

Can you please test with Grav 1.4 RC with Admin 1.7 RC, because I can't replicate it there. I think a bug I fixed in handling frontmatter might of fixed this too.

@rhukster
Copy link
Member

rhukster commented Mar 7, 2018

edit_frontmatter-delete___grav

Screenshot to show a save on a test page.

@RobLui
Copy link
Contributor

RobLui commented Mar 7, 2018

testing atm

@RobLui
Copy link
Contributor

RobLui commented Mar 8, 2018

Before:
Before

After:
After

Issue still persists

Admin version:
| 230 | Admin Panel | admin | v1.7.0-rc.3 | installed |

@rhukster
Copy link
Member

rhukster commented Mar 8, 2018

@RobLui can you zip up your Grav site and let me download it? I think this might be related to a plugin or at least a configuration setting.

@rhukster
Copy link
Member

rhukster commented Mar 8, 2018

Also what page type is this? Does it happen for all including default ?

@mpduarte
Copy link

mpduarte commented Mar 8, 2018

I've been having the same issue, also having the same issue after upgrading to the RC releases. The bug is occurring on a template other than default, However just tested using default template, same thing occurs.

@mpduarte
Copy link

mpduarte commented Mar 8, 2018

@rhukster I can give you a zip copy of my site, as long as you don't need anything in pages or accounts. Would that suffice for troubleshooting?

@RobLui
Copy link
Contributor

RobLui commented Mar 8, 2018

Can you check Slack :) ? Pm'ed you @rhukster

@rhukster
Copy link
Member

rhukster commented Mar 9, 2018

Found it and fixed.

@rhukster rhukster closed this as completed Mar 9, 2018
@rhukster
Copy link
Member

rhukster commented Mar 9, 2018

c15fe28

@RobLui
Copy link
Contributor

RobLui commented Mar 9, 2018

AWESOME :-)

@mpduarte
Copy link

mpduarte commented Mar 9, 2018

Thanks @rhukster , patched our deployment with the change, and everything is working great over here. Appreciate it!

@cniweb
Copy link
Author

cniweb commented Mar 15, 2018

Thanks @rhukster 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants