Initialize session on setup #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the plugin compatible with `system.session.initialize = false` which makes it possible to have no session cookie (for frontend users) while the admin login still works.
|
I think the fix itself is fine, though as session used to be opened very early (before plugins were initialized), some plugins may break if the You're firing the event very early, so changes of breaking anything (except for non-admin plugins) is very low. |
mahagr
approved these changes
Jun 1, 2018
This was referenced Jun 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the plugin compatible with
system.session.initialize = falsewhich makes it possible to have no session cookie (for frontend users) while the admin login still works.The change seems to work fine, but I'm pretty new to Grav and it is entirely possible that the initialization should happen somewhere in the login or form plugins. Any feedback appreciated.