Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the setting to enable secure deletion of pages #1752

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

lauroguedes
Copy link
Contributor

To avoid accidental deletion, I implemented a secure deletion system in which the user has to type the word DELETE into a text field for the confirm deletion button to be enabled. By default this plugin setting is disabled.

demo-secure-delete

@rhukster
Copy link
Member

This is pretty cool! Good idea

@rhukster rhukster requested review from mahagr and w00fz September 16, 2019 21:41
@lauroguedes
Copy link
Contributor Author

Yes, I got the idea after I accidentally lost some data, as the button was the same color as cancel and there was no turning back this was a solution that solved

@lauroguedes
Copy link
Contributor Author

Another thing that could be done is to have a specific permission to create, edit and delete pages in admin, so that would create another layer of security.

@mahagr
Copy link
Member

mahagr commented Sep 17, 2019

There are already separate permissions for different page actions built into the upcoming Flex pages. :)

@rhukster rhukster merged commit d0492c9 into getgrav:develop Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants