Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while updating antimatter theme #658

Closed
zerbbi opened this issue Jun 8, 2016 · 13 comments
Closed

Error while updating antimatter theme #658

zerbbi opened this issue Jun 8, 2016 · 13 comments

Comments

@zerbbi
Copy link

zerbbi commented Jun 8, 2016

I triet to update antimatter theme and this error showed and update failed.
graverror

Running Grav v1.1.0-rc.1 - Admin v1.1.0-rc.2 on localhost (wamp server with apache 2.4.9 on windows 10 machine)

@flaviocopes
Copy link
Contributor

Can you open the devtools while doing so? The network panel should show a error request. (I am familiar with Chrome), should look like:

screen shot 2016-06-09 at 12 36 43

What is the content of the request tab for that failed request?

screen shot 2016-06-09 at 12 36 54

@flaviocopes
Copy link
Contributor

No issues with updating it. Can you install any new theme? Does it work?

@blurkness
Copy link

I tried both. Update antimatter and install new themes and both of them just appear the overlay modal saying "Updating" or "Installing" but with no requests in network tab and no JS error or anything in console.

I'll try to debug deeper.

@zerbbi
Copy link
Author

zerbbi commented Jun 17, 2016

I got the same error while trying to update grav to rc2. Update did not finish. Screenshot:
graverror2

@zerbbi
Copy link
Author

zerbbi commented Jun 17, 2016

I tried clean install of grav rc2 and problems are fixed. everything is working

@zerbbi
Copy link
Author

zerbbi commented Jun 17, 2016

Error happened again 😢 Tried cleaning cache on grav rc2
graverror3

@zerbbi
Copy link
Author

zerbbi commented Jun 17, 2016

I found that the problem only happens, when i change Parameter separator in configuration. When i change it to ; (for apache running on win), i get JSON errors when cleaning cache, changing themes, saving pages, etc... When separator is set to default :, everything is ok.

@flaviocopes
Copy link
Contributor

This is weird. Apache running on Windows is not supposed to work with the colon in the request. That's why Grav tells to use a semicolon instead. BUT your specific Apache implementation might not work with ;, and work with :. Need to test it out, but if it works for you, it should work also in other windows setups.

@zerbbi
Copy link
Author

zerbbi commented Jun 20, 2016

Sorry for misunderstanding, i meant that when i set separator to :, I am not getting JSON errors, but parameters like pagination are not working, of course. When I set separator to ;, parameters are working, but when i try to do anything related with javascript in admin panel, like save page content, change theme, clear cache, etc..., i get JSON errors.

@flaviocopes
Copy link
Contributor

I'm on this today, I've replicated the issue and I'm looking for a fix. Keeping you posted.

@flaviocopes
Copy link
Contributor

Looks like a recent issue. Part of the fix is in Grav getgrav/grav@1bf4428

@flaviocopes
Copy link
Contributor

Took me a while to find out. Using ; should work fine now.

@zerbbi
Copy link
Author

zerbbi commented Jun 21, 2016

thank you @flaviocopes, it looks like everything is working 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants