Adding a per-page option to control breadcrumb generation #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…articular page by adding appropriate configuration in the page's YAML frontmatter. The functionality is implemented as part of the main loop for generating breadcrumb information in Breadcrumbs::build(). Each page's frontmatter is checked and, if configuration is found indicating that breadcrumbs beneath the current page should be truncated, the $hierarchy variable in which breadcrumb information is accumulated is emptied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a per-page option named
may_descend. When added to a page's YAML frontmatter, the plugin omits the breadcrumbs of any page which is beneath the current page in the hierarchy.It also adds extensive commenting. I wrote that as part of working to understand the existing code. We can of course remove it if we feel it is too verbose.