Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nextgen-editor] Ul mssing in child elements #123

Closed
xf- opened this issue Jun 30, 2021 · 8 comments
Closed

[nextgen-editor] Ul mssing in child elements #123

xf- opened this issue Jun 30, 2021 · 8 comments
Assignees
Labels
enhancement New feature or request nextgen-editor NextGen Editor plugin

Comments

@xf-
Copy link

xf- commented Jun 30, 2021

Markdown output from editor (here using ui tabs, but also with other elements)

[ui-tabs]
[ui-tab]
*   fgfgfg
*   dfg
[/ui-tab]
[ui-tab]
*   fdg
*   dfg
[/ui-tab]
[/ui-tabs]

Code
image

Temp fix is expert mode and add an empty line after the last list item, but the next save with nextgen-editor will remove the line and the issue is back.

@rhukster
Copy link
Member

I have a couple of questions for you:

  1. is that markdown example exactly how it looks in the .md file?
  2. What is your shortcode-core parser configure to use? It should use "regular" parser.

@rhukster rhukster self-assigned this Jun 30, 2021
@rhukster rhukster added nextgen-editor NextGen Editor plugin question Further information is requested labels Jun 30, 2021
@xf-
Copy link
Author

xf- commented Jun 30, 2021

  1. yes, c&p from md file
  2. All of them. Switched around to maybe fix it.

@xf-
Copy link
Author

xf- commented Jul 10, 2021

i tried to debug the issue with youtube shortcode first and saw your comment in thunderer/Shortcode#65

[youtube autoplay="1" rel="0"]https://www.youtube.com/watch?v=YGgdfrkBlaU[/youtube]
https://www.youtube.com/watch?v=YGgdfrkBlaU[/youtube]

I think in general the trim is an issue, because it breaks workarounds a list wants a empty line markdown to next element and the shortcodes are always nextline.

@w00fz
Copy link
Member

w00fz commented Sep 22, 2021

I think this is a shortcode issue, the rendered shortcode missing the <ul> wrapper around the second tab, new lines etc, should be handled by Shortcode and not NextGen.

@rhukster
Copy link
Member

I will investigate this shortly.

@xf-
Copy link
Author

xf- commented Sep 23, 2021

@rhukster thx

For me, it sounds like a bug in new editor, because it touches empty lines and that is often used in Markdown to separate stuff. Markdown from Old editor will break in new editor.

More or less 2 Bugs

  • Wrong rendering -> properly short code plugin
  • Adding an empty line after a list, so the list is standalone and markdown stops - Editor removes it is from md file.

@w00fz w00fz added enhancement New feature or request and removed question Further information is requested labels Sep 28, 2021
@w00fz
Copy link
Member

w00fz commented Sep 28, 2021

hey @xf-
I fixed the issue by enforcing an extra empty line before and after the content of shortcodes that are nested ([ui-tab], [ui-accordion]) when saving.

This wasn't really an issue with NextGen Editor per se, so you will find this fix in the v5.0.7 of Shortcode Core plugin.

Cheers,

@xf-
Copy link
Author

xf- commented Sep 28, 2021

@w00fz in my eyes an issue from the editor, because it changes the source code, compared to old one. But it is a solution.

Edit: You changed the JS part. I used the plugin as template, because the documentation has not a lot of examples and having something publicly available related with this issue helped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nextgen-editor NextGen Editor plugin
Projects
None yet
Development

No branches or pull requests

3 participants