-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to use same session for front end and admin #1085
Comments
A PR would be considered as long as the default state was 'split' sessions. |
I'm not sure if that's ok but if it is inevitable, I think we should at least have it explained in the description (tooltip). "By changing this field, your session will become invalid and you will be required to login again." ... something along those lines |
I wouldn't say inevitable.. it shouldn't be too hard to migrate the session to another namespace. I haven't had a closer look at possible pitfalls yet though - is there anyone around who has more experience with the admin session? |
I think having a proper description with this side-effect explained is fine. I guess that when you enable this setting, admin will use the site session, so that's inevitable unless the opposite happens (site uses the admin session), which I don't know if it's doable / nicer. |
done. |
Note that this value is not documented in the docs. (It is shown in the example, but not explained.) |
Currently the session is split up in front end and admin. While this might be desired in some cases, there are also other cases where you want a shared session - e.g. when displaying an admin bar with links to edit or create a new page, currently logged in user name etc.
I propose that there should be a session setting to enable/disable sharing the session (disabled by default).
I can create a PR if you agree on this.
The text was updated successfully, but these errors were encountered: