Fix Windows routing with built-in server #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strips backward-slashes from Medium.php's and ImageMedium.php's url() method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip backward-slashes from Medium.php's and ImageMedium.php's url() method, both ahead of and trailing the string. As this uses
trim()and backward-slashes it should be safe across systems, because only Windows actually relies on them even though PHP will allow either forward- or backward-slashes in paths.This solves Admin 1119. Tested with PHP PHP 7.0.7 and Grav from current source, on Windows 10 x64, using
php -S localhost:80 -t "C:\Users\Ole Vik\Downloads\Grav\develop" system/router.phpto run the server.