Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder page ordering doesn't obey 99+ #1524

Closed
l3aconator opened this issue Jun 9, 2017 · 9 comments · Fixed by #1564
Closed

Folder page ordering doesn't obey 99+ #1524

l3aconator opened this issue Jun 9, 2017 · 9 comments · Fixed by #1564
Labels

Comments

@l3aconator
Copy link

The folder numerical ordering doesn't obey the order over 99. Anything over 99 puts them back at the top of the order structure on render instead of continuing sequentially.

@flaviocopes
Copy link
Contributor

Shouldn't be the case, just tested.
You mean in a frontend collection? How is the collection defined? Can you paste the parent page header?

@l3aconator
Copy link
Author

---
title: 'TeamSnap Team Players - Employee Bios'
menu: 'Team Players'
metadata:
    description: 'The talented men and women (and dog!) that work together to bring you TeamSnap products and services.'
content:
    items: '@self.children'
visible: true
---

And then all the child pages are labeled numerically do order them and allow for content editors to reorder them the way they want.

@flaviocopes
Copy link
Contributor

I assumed you're referring to the order in the frontend, is this right? Or are you talking about the Admin interface?

@l3aconator
Copy link
Author

The admin interface for content editors shows the order correctly. When it renders on the frontend, it is out of order, with 100+ showing up first and then 1+. So, the list is up to 107. Numbers 100-107 show up at the top of the list and then start counting from 1.

@flaviocopes
Copy link
Contributor

I cannot replicate the problem. Can you PM me your user/ folder via Slack? This will make sure I test your same exact code.

@w00fz
Copy link
Member

w00fz commented Jul 10, 2017

I can actually reproduce this on linux only. On mac this is fine.

@mahagr
Copy link
Member

mahagr commented Jul 10, 2017

@flaviocopes Looks like you have overridden SORT_NATURAL with SORT_REGULAR in Pages::buildSort() function. Might have something to do with the wrong ordering.

@w00fz
Copy link
Member

w00fz commented Jul 10, 2017

@l3aconator mind testing my fix in #1564 ?

@l3aconator
Copy link
Author

@w00fz Will do. Our production servers are linux. I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants