Install plugins and themes in correct multisite folders #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes we definitely plan on moving the CLI stuff to streams. Probably before Grav 2.x, Maybe even Grav 1.2. |
|
Thanks btw. |
|
As mentioned in getgrav/grav-plugin-admin/issues/319 the easiest work around we now use is to create symlinks for plugins, themes in sites. We do the same for pages/pagetrees from other sites we want to "reuse" in other sites. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having multisite folders with different user folders and one installs a plugin or a theme, Grav always installs it in the "root" folders like
user/pluginsoruser/themes.This PR addresses the issue (cf. getgrav/grav-plugin-admin#319) and fixes it with full backward-compatibilty and without any change to the Grav GPM package system.
However in the future I advise to use streams in the package system, which are resolved to the respective folders in the grav installs of the users. This PR is a step to this direction and (I guess) will be tackled in Grav v2.x.