Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dangerous extension .js includes .json #3060

Closed
stephan-strate opened this issue Nov 10, 2020 · 0 comments
Closed

Dangerous extension .js includes .json #3060

stephan-strate opened this issue Nov 10, 2020 · 0 comments

Comments

@stephan-strate
Copy link
Contributor

Having .js listed as Dangerous Extension (Configuration -> Security or config/security.yaml) leads to errors when trying to upload a .json file using the PageMedia upload.

image

Yes, .json files (JavaScript Object Notation) are somehow connected with .js files. But I think it should be possible to upload them (.xml and .yaml files can be upload aswell).
@stephan-strate stephan-strate mentioned this issue Nov 11, 2020
Merged
rhukster pushed a commit that referenced this issue Nov 11, 2020
@stephan-strate
Check exact extension in checkFilename utility (#3061)
9b2b909 
* Fix uploads_dangerous_extensions checking (#3060)

* Remove redundant prefixing of `.` to extension (#3060)
mahagr pushed a commit that referenced this issue Nov 17, 2020
@stephan-strate @mahagr
Check exact extension in checkFilename utility (#3061)
ae6f0b5 
* Fix uploads_dangerous_extensions checking (#3060)
* Remove redundant prefixing of `.` to extension (#3060)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephan-strate