Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm dependencies conflict in template #901

Closed
epogrebnyak opened this issue Apr 28, 2024 · 9 comments
Closed

npm dependencies conflict in template #901

epogrebnyak opened this issue Apr 28, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@epogrebnyak
Copy link

Describe the bug

In https://github.com/gethinode/template npm install results in

npm ERR! While resolving: eslint-config-standard@17.1.0
npm ERR! Found: eslint-plugin-n@17.3.1
npm ERR! node_modules/eslint-plugin-n
npm ERR!   dev eslint-plugin-n@"^17.3.1" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint-plugin-n@"^15.0.0 || ^16.0.0 " from eslint-config-standard@17.1.0
npm ERR! node_modules/eslint-config-standard
npm ERR!   dev eslint-config-standard@"^17.1.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: eslint-plugin-n@16.6.2
npm ERR! node_modules/eslint-plugin-n
npm ERR!   peer eslint-plugin-n@"^15.0.0 || ^16.0.0 " from eslint-config-standard@17.1.0
npm ERR!   node_modules/eslint-config-standard
npm ERR!     dev eslint-config-standard@"^17.1.0" from the root project
@epogrebnyak epogrebnyak added the bug Something isn't working label Apr 28, 2024
@markdumay
Copy link
Collaborator

Thanks for reporting the issue, however, I cannot reproduce it. When submitting a bug in the future, would you mind filling in the template? It includes a section on how to reproduce the error and it clarifies the host environment.

Regarding the submitted error logs, the eslint-config-standard package is not compatible with the latest eslint-plugin-n yet. See standard/eslint-config-standard#410 for the latest status. For now, the Hinode (template) repository uses eslint-plugin-n v16.6.2 instead (see PR gethinode/template#311 for an automated test).

I suspect you upgraded the npm modules locally (e.g. npx npm-check-updates) and ran into this issue when running npm install? My advice would be to use the current package.json file as is.

@epogrebnyak
Copy link
Author

Thank you for prompt response. There where not many steps involved rather than following the tutorial to create the repo from template and run npm install. I did not change package.json (I think). I could get past the issue with npm install --force. I can try repoduce the error once more and report it back here.

@ammakr
Copy link

ammakr commented May 10, 2024

I got the same issue on debian 12. is there any way to handle it in a clean way, without using --force?

@ammakr
Copy link

ammakr commented May 10, 2024

I found the solution, just change one of the dep version: "eslint-plugin-n": "^16.0.0",

@epogrebnyak
Copy link
Author

Thanks! At package.json is that?

@markdumay
Copy link
Collaborator

@epogrebnyak, which host OS are you using? I cannot reproduce the error on macOS or Ubuntu (via GitHub codespaces), so perhaps it's tied to a specific host environment. I'm fine to adjust the base repositories, however, I'd like to understand the cause of the issue a bit better.

@epogrebnyak
Copy link
Author

Should have said i'm on Windows

@ammakr
Copy link

ammakr commented May 12, 2024

Thanks! At package.json is that?

Yep, and it is not some OS related problem, i happen to come across this on debian 12.

@markdumay
Copy link
Collaborator

The issue should be solved now (see v0.14.0 for details). PR gethinode/template#311 tracks the progress of eslint-plugin-n.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants