Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add type select for Scrutiny Widget #596

Closed
Xm798 opened this issue Dec 1, 2022 · 3 comments
Closed

[Feature Request] Add type select for Scrutiny Widget #596

Xm798 opened this issue Dec 1, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@Xm798
Copy link

Xm798 commented Dec 1, 2022

Description

On the scrutiny's settings panel, we can change the device status between Smart, Scrutiny and Both. I changed it to "Smart" because I only want to get the information of smartctl and ignore failures scrutiny detected. But the widget doesn’t seem to be able to configure the device status type, which always shows that there are several FAILED disks.

So we want a switch to select the type of status report to be consistent with the display on scrutiny's panel.

Thanks so much !

Other

Ref AnalogJ/scrutiny#275 and https://github.com/AnalogJ/scrutiny/blob/d8d56f77f9e868127c4849dac74d65512db658e8/webapp/frontend/src/app/shared/device-status.pipe.ts#L12-L17.

@Xm798 Xm798 added the enhancement New feature or request label Dec 1, 2022
@Tarow
Copy link
Contributor

Tarow commented Dec 4, 2022

I addressed this issue in my latest PR.

@Xm798
Copy link
Author

Xm798 commented Dec 5, 2022

I addressed this issue in my latest PR.

That's great, thanks a million!

@Xm798 Xm798 closed this as completed Dec 5, 2022
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants