Skip to content

Commit 13eb4be

Browse files
committed
http-175 Address review comments
Signed-off-by: davidradl <david_radley@uk.ibm.com>
1 parent d6b555a commit 13eb4be

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## [Unreleased]
44

55
- Amend to not log HTTP request response and header values by default.
6+
- Added http 2 support.
67

78
## [0.22.0] - 2025-10-03
89

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -427,10 +427,9 @@ that implements interface `HttpPostRequestCallbackFactory<HttpRequest>` to creat
427427
of class `CustomHttpSinkPostRequestCallbackFactory` in `resources/META-INF/services/org.apache.flink.table.factories.Factory` file
428428
and then reference identifier `rest-sink-logger` in the HttpSink DDL property field `gid.connector.http.sink.request-callback`.
429429

430-
A default implementation that logs those pairs as *INFO* level logs using Slf4j
431-
([Slf4jHttpPostRequestCallback](src/main/java/com/getindata/connectors/http/internal/table/sink/Slf4jHttpPostRequestCallback.java))
432-
is provided.
433-
430+
A default implementation that logs those pairs as *INFO* level logs using Slf4j ([Slf4jHttpPostRequestCallback](src/main/java/com/getindata/connectors/http/internal/table/sink/Slf4jHttpPostRequestCallback.java)) is provided.
431+
If you would like to log more http content (that maybe contain sensitive information), then you can provide a customized version
432+
of this callback; for inspiration on how to customize in this way, look back in the git history of this file.
434433

435434
- Http Lookup Source processes responses that it gets from the HTTP endpoint along their respective requests. One can customize the
436435
behaviour of the additional stage of processing done by Table Function API by implementing

src/main/java/com/getindata/connectors/http/internal/table/lookup/JavaNetHttpPollingClient.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,6 @@ private HttpRowDataWrapper processHttpResponse(
210210
boolean isError) throws IOException {
211211

212212
this.httpPostRequestCallback.call(response, request, "endpoint", Collections.emptyMap());
213-
request.getHttpRequest().uri();
214213
var responseBody = response.body();
215214

216215
log.debug("Received status code [{}] for RestTableSource request", response.statusCode());

0 commit comments

Comments
 (0)