Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume create does not work with latest kedro-docker image #228

Open
marrrcin opened this issue Mar 20, 2023 · 3 comments
Open

Volume create does not work with latest kedro-docker image #228

marrrcin opened this issue Mar 20, 2023 · 3 comments

Comments

@marrrcin
Copy link
Contributor

The latest update to kedro-docker (which we've introduced BTW 😀) replaced /home/kedro with /home/kedro_docker due to name collision if someone had __init__.py in their project directory - which is a fine fix.
In this plugin however, we still have the /home/kedro path hard-coded e.g. here

We need to expose a config for that, so it's settable by the end-user, similarly to kedro-azureml: https://github.com/getindata/kedro-azureml/blob/c220ac31c062d4cceda17b6fcec7053178d47217/kedro_azureml/config.py#L81

@szczeles
Copy link
Contributor

szczeles commented Mar 20, 2023

@marrrcin It were not us ;-) kedro-org/kedro-plugins#28

@marrrcin
Copy link
Contributor Author

Aw, ok 🙈

@marrrcin
Copy link
Contributor Author

The issue also applies to the feature store_kedro_outputs_as_kfp_artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants