Can not parse openapi spec with recursive references

[hottestseason]

It looks this library fail to parse spec which has recursive references like this
https://github.com/hottestseason/kin-openapi/tree/f9ccdc2e69d360c4f17a7c94189526457e90b1f3/openapi3/testdata/recursiveRef

openapi: "3.0.3"
info:
  title: Recursive refs example
  version: "1.0"
paths:
  /foo:
    $ref: ./paths/foo.yml
components:
  schemas:
    Foo:
      $ref: ./components/Foo.yml
    Bar:
      $ref: ./components/Bar.yml

get:
  responses:
    "200":
      description: OK
      content:
        application/json:
          schema:
            type: object
            properties:
              foo:
                $ref: ../openapi.yml#/components/schemas/Foo

type: object
properties:
  bar:
    type: array
    items:
      $ref: ../openapi.yml#/components/schemas/Bar

type: string
example: bar

It works when loading bundled version such as using swagger-cli bundle

[roee88]

@fenollp I don't think that this one is fixed. A minimal example to reproduce:

openapi: 3.0.1
info:
  title: Recursive refs example
  version: "1.0"
paths: {}
components:
  schemas:
    Complex:
      type: object
      properties:
        parent:
          $ref: '#/components/schemas/Complex'

Should I open a different issue?

[chrisdostert]

@fenollp @hottestseason thanks for all the hard work and a the great project. I'm still seeing this as well so I don't think it's fixed yet. The issue I'm hitting is the same as @roee88 's example where my schema is recursive. The result is, golang model generation hangs indefinitely.

[fenollp]

Ah sorry I missed that @roee88
Yes please open a dedicated issue and maybe a PR with the looping snippet.
There are loop detection mechanisms in place and they appear not to handle this kind of code...

kin-openapi/openapi3/loader.go

Line 50 in e9b36da

visitedSchema map[*Schema]struct{}

PRs welcomed!