Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] New sticky Writer Toolbar in Block Text preview inconsistent with Writer Field #5502

Closed
ovenum opened this issue Aug 24, 2023 · 0 comments · Fixed by #5528
Closed

[v4] New sticky Writer Toolbar in Block Text preview inconsistent with Writer Field #5502

ovenum opened this issue Aug 24, 2023 · 0 comments · Fixed by #5528
Milestone

Comments

@ovenum
Copy link
Contributor

ovenum commented Aug 24, 2023

Description

The new sticky Writer Toolbar behaves differently when rendered within the WriterField component or within a Block Text preview component.

Expected behavior
The TextPreview Toolbar position, size and spacing to be more consistent with the Writer Field toolbar.

  • More spacing between the toolbar and field content.
  • The Toolbar to extent across the available horizontal space. Like it does in the Field.

Screenshots
image
WriterField Toolbar with good spacing to the fields text content and stretching across horizontally.

image

Toolbar rendered inside TextPreview component has not enough spacing to text content and does not fill the available horizontal space, which looks odd.

To reproduce

Create a blocks field with the blueprint below and add a new Text Block with some content.

type: blocks
fieldsets:
  text:
    name: field.blocks.text.name
    icon: text
    wysiwyg: true
    preview: text
    fields:
      text:
        type: writer
        label: Text
        headings:
          - 2
          - 3
        toolbar:
          inline: false 

Your setup

Kirby Version
4.0.0-alpha.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants