Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Multiselect field always offers search & create features / cuts off long options #5533

Closed
3 tasks done
twiro opened this issue Aug 31, 2023 · 2 comments · Fixed by #5537
Closed
3 tasks done

[v4] Multiselect field always offers search & create features / cuts off long options #5533

twiro opened this issue Aug 31, 2023 · 2 comments · Fixed by #5537
Milestone

Comments

@twiro
Copy link

twiro commented Aug 31, 2023

Description

  1. The multiselect field always shows a search/filter-field (ignoring the blueprint-setting search: false)
  2. The multiselect field always comes up with a misleading create-option whenever a search for a non-existing option is performed. (This happens with both static and dynamic options, using the feature doesn't do anything at all.)
  3. The multiselect field cuts of options with long titles due to its limited width.

Expected behavior

  1. The multiselect field should not contain a create-option by default. (if at all, this would have to be extensively configurable)
  2. The multiselect field should not contain a search/filter-field if the blueprint is set to search: false.
  3. The multiselect field should not cut off options as long as there is enough space left to show them properly.

Screenshots

kirby-multiselect-bug-v4

To reproduce

  1. Take the first example from the official multiselect-field-reference and try it out in the latest alpha-release.
  2. Add/Remove the search: false-setting to the blueprint.
  3. Try to use the create-option.
  4. Try out some options with really long names

Your setup

Kirby Version: 4.0.0-alpha.7.

@bastianallgeier
Copy link
Member

Thanks for the issue. When there's more than a single problem, it's super helpful for us if you break it down into separate issues. Then we can check them off individually when a fix is ready. I've turned this now into a todo list and might also break it down some more later.

@twiro
Copy link
Author

twiro commented Aug 31, 2023

Thanks for the issue. When there's more than a single problem, it's super helpful for us if you break it down into separate issues. Then we can check them off individually when a fix is ready. I've turned this now into a todo list and might also break it down some more later.

Makes sense and I will try better next time – this was my first issue report in this repo.

And thank you for the quick response and fixes and great work in general – Version 4 feels great so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants