Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Image card size doesn't working correctly in drawer #5849

Closed
afbora opened this issue Oct 22, 2023 · 5 comments · Fixed by #5873
Closed

[v4] Image card size doesn't working correctly in drawer #5849

afbora opened this issue Oct 22, 2023 · 5 comments · Fixed by #5873
Assignees
Milestone

Comments

@afbora
Copy link
Member

afbora commented Oct 22, 2023

Description

Image card size doesn't working correctly in drawer due to @container queries.

fields:
  blocks:
    type: blocks
    fieldsets:
      test:
        name: Test
        icon: image
        fields:
          image:
            label: Image
            type: files
            layout: cards
            size: huge

Screenshots

image (8)

Kirby Version
Beta.3 (v4/develop)

@afbora afbora added this to the 4.0 milestone Oct 22, 2023
@afbora afbora changed the title [v4] Image card size doesn't working in drawer [v4] Image card size doesn't working correctly in drawer Oct 22, 2023
@afbora
Copy link
Member Author

afbora commented Oct 22, 2023

I realized that this issue not only for drawer:

fields:
  logo:
    type: files
    label: "Logo"
    multiple: false
    query: page.images
    uploads: image
    layout: cards
    size: huge
    width: 1/2

  logoInverse:
    type: files
    label: "Logo inverse"
    multiple: false
    query: page.images
    uploads: image
    layout: cards
    size: huge
    width: 1/2

screen-capture-1710-Test - Mægazine-localhost

@tobimori
Copy link
Contributor

Related: https://discord.com/channels/525634039965679616/1111220342522904706/1159872662252814426

@distantnative
Copy link
Member

Tbh to me it seems more correct in v4 than v3. huge !== full width, or? But maybe we should add a size: full or similarly named?

@tobimori
Copy link
Contributor

Would be a breaking change, still

@distantnative
Copy link
Member

That's ok - for breaking changes that improve the system (cause the old way was actually broken/not right) such a major version step is actually the perfect time IMO.

@distantnative distantnative self-assigned this Oct 24, 2023
@distantnative distantnative modified the milestones: 4.0, 4.0-beta.3 Oct 24, 2023
@distantnative distantnative linked a pull request Oct 24, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants