feat: add a screenshot script #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchelkowski
requested review from
tbazelczuk and
a user
and removed request for
a team
pawelhertman
approved these changes
Jan 25, 2022
scripts/screenshot.js
Outdated
Comment on lines
5
to
9
| (async () => { | ||
| await new StepRunner([ | ||
| { step: ScreenshotStep, config: screenshotStepConfig }, | ||
| ]).run(); | ||
| })(); |
There was a problem hiding this comment.
Suggested change
| (async () => { | |
| await new StepRunner([ | |
| { step: ScreenshotStep, config: screenshotStepConfig }, | |
| ]).run(); | |
| })(); | |
| (() => { | |
| new StepRunner([ | |
| { step: ScreenshotStep, config: screenshotStepConfig }, | |
| ]).run(); | |
| })(); |
or maybe even
Suggested change
| (async () => { | |
| await new StepRunner([ | |
| { step: ScreenshotStep, config: screenshotStepConfig }, | |
| ]).run(); | |
| })(); | |
| (() => new StepRunner([ | |
| { step: ScreenshotStep, config: screenshotStepConfig }, | |
| ]).run())(); |
(not sure, too much brightscript on daily basis 😅)
There was a problem hiding this comment.
changed to:
new StepRunner([
{ step: ScreenshotStep, config: screenshotStepConfig },
]).run();
|
Scan submitted to Checkmarx |
|
Cx-SAST SummaryTotal of 3 vulnerabilities Checkmarx Scan Summary
Violation Summary
View more details on Checkmarx UI Cx-SAST Details
Cx-SCA SummaryTotal Packages Identified: 357
Cx-SCA vulnerability result overview
|
bchelkowski
force-pushed
the
feat/add-screenshot-script
branch
from
17f7f31
to
f93fada
Compare
tbazelczuk
approved these changes
Jan 26, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Jan 26, 2022
# [1.2.0](v1.1.4...v1.2.0) (2022-01-26) ### Features * add a screenshot script ([#56](#56)) ([54c7244](54c7244))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshotscript that takes a screenshot of the dev app.Screenshots are saved under the screenshotDir path from .kopytkorc or if such field is not provided the default directory is set to
/dist.The script saves it under filename
Screenshot_<Date as ISOString>.jpgRequirements:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO