-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some entity processing errors to 400.28 #854
Labels
entities
Multiple Encounter workflows
Comments
I also think we should try to use more specific Problems that already exist when those are appropriate. For example, Problems like |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #844 introduces a new Problem
Problem.user.invalidEntity (400.28)
to return when creating an entity from JSON fails because of some formatting or validation problem. New code around JSON entity extraction uses this problem.Many of the previous validation error cases throw
Problem.user.entityViolation (409.14)
, which is a conflict problem rather than a bad request problem. This problem was made back when we started parsing submission XML to create entities and foresaw entity conflict as one possible problem.I think we could go back and update pure validation errors to throw the
400.28
error instead of409.14
. The names could also be better -entityConflict
andinvalidEntity
or something.The text was updated successfully, but these errors were encountered: