Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create entity without approval #864

Closed
5 tasks
sadiqkhoja opened this issue May 9, 2023 · 3 comments
Closed
5 tasks

Create entity without approval #864

sadiqkhoja opened this issue May 9, 2023 · 3 comments
Assignees
Labels
behavior verified Behavior has been manually verified enhancement New feature or behavior entities Multiple Encounter workflows

Comments

@sadiqkhoja
Copy link
Contributor

sadiqkhoja commented May 9, 2023

Right now, entities are created when someone approves the submission. But for many workflows, this is an inconvenience.

As a project manager, I should be able to configure whether entities are created on submission receipt or on approval.

Release criteria can be found here.

Additional details:

  • Configuration flag will be at the Dataset level
  • By default, approval will not be required
  • Existing datasets will still require approval, user would be able to turn it off
  • The flag will be set via API, it cannot be defined in form definition

Backend:

  • GET /datasets and /dataset/:name should return the current value of the flag
  • PATCH /datasets/:name should update the value of the flag
  • Update entity worker

Frontend:

  • display the value on list of dataset page
  • have ability to update the value of the flag
@sadiqkhoja sadiqkhoja self-assigned this May 9, 2023
@sadiqkhoja sadiqkhoja added the entities Multiple Encounter workflows label May 9, 2023
@matthew-white matthew-white added enhancement New feature or behavior needs testing Needs manual testing needs design review Needs verification from designer labels May 18, 2023
@matthew-white
Copy link
Member

Closed by #868, #870, and getodk/central-frontend#795.

@srujner
Copy link

srujner commented May 25, 2023

Tested with Success!

@dbemke
Copy link

dbemke commented May 25, 2023

Tested with success!

@srujner srujner added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels May 25, 2023
@matthew-white matthew-white removed the needs design review Needs verification from designer label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified Behavior has been manually verified enhancement New feature or behavior entities Multiple Encounter workflows
Projects
Status: ✅ done
Development

No branches or pull requests

4 participants