Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of a form in quotation marks is sorted in a different way in "Forms” tab and "Form Access” tab #713

Open
dbemke opened this issue Sep 19, 2024 · 1 comment
Labels
frontend Requires a change to the UI

Comments

@dbemke
Copy link

dbemke commented Sep 19, 2024

Problem description

Name of a form in quotation marks is sorted in a different way in "Forms” tab and "Form Access” tab. In "Forms” it’s the first for on the list. In "Form Access” it’s sorted according to the first letter order.

URL of the page

https://staging.getodk.cloud/#/projects/20/form-access

Steps to reproduce the problem

  1. Upload a form with a name in quotation marks (e.g.
    form_quotes.xlsx.txt )
  2. Go to the "Forms" tab and check the list.
  3. Go to the "Form Access" tab and check the list.

Screenshot

fastExternal
fastExternalFormAcces

Expected behavior

Central version shown in version.txt

https://test.getodk.cloud/
versions:
f21b33a (v2024.1.0)
3fb0c22b1cbdc3a6004963afcc3847a82c09307d client (v2024.1.0)
b4754cf52bfa64b1ca841bc9ccb64a38726398e8 server (v2024.1.0)
https://staging.getodk.cloud/
versions:
2dec77e (v2024.1.0-7-g2dec77e)
+c5e3023ff196191438db7b0142bb6b9dbd58c778 client (v2024.1.0-40-gc5e3023f)
+3ae8a69011f3839b60ecc9fdda770faa408d16d4 server (v2024.1.0-35-g3ae8a690)

Browser

Chrome, Firefox

@matthew-white
Copy link
Member

This points to differences in how Backend and Frontend sort alphabetically. The order of the forms in the Forms tab is generated by Frontend, while the order in the "Form Access" tab is generated by Backend. The order of the form list shown in Collect is also generated by Backend, so I think it'd be good for Frontend to match that.

Backend actually returns forms to Frontend already sorted alphabetically, so I think all Frontend needs to do is order forms in that original order when it's asked to list forms alphabetically. In other words, I don't think Frontend should do its own, independent alphabetical sorting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Requires a change to the UI
Projects
None yet
Development

No branches or pull requests

2 participants