Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form filling: Geopoint with no appearance #249

Open
alyblenkin opened this issue Nov 11, 2024 · 1 comment · May be fixed by #300
Open

Form filling: Geopoint with no appearance #249

alyblenkin opened this issue Nov 11, 2024 · 1 comment · May be fixed by #300
Assignees
Milestone

Comments

@alyblenkin
Copy link
Collaborator

alyblenkin commented Nov 11, 2024

User stories

Feedback when trying again

  1. As a user attempting to get better accuracy by trying again
    I want to see the progress indicator
    So that I know something is actively happening and not “saved” yet

  2. Given I’ve clicked “get location”
    When I see the spinner and the button is disabled
    Then I know I need to wait until the location is captured and the button becomes active

  3. As a user wanting to get good accuracy
    I want to see feedback on the prompt
    So that I know whether the location accuracy is adequate or not

Displaying accuracy as soon as the location is available

  1. As a user wanted to save a location
    When I look at the location dialog
    Then I should see the accuracy as soon as it's available

  2. As a user wanted to save a location
    When I look at the location dialog
    I shouldn’t see latitude, longitude, and altitude yet since I do not commonly use them, but I want to know the time taken to capture the location.

Once the location is captured

  1. Given I’ve saved the location
    When I look at the container
    Then I should see “<poor|good> location: Accuracy: 14.15m, Latitude: 62.99352, Longitude: 98.61553"
    So that I know it was adequate

Error messages

  1. Given I haven’t enabled location permissions
    And the question is required
    When I click submit
    Then I should see a stacked error message

Read-only

  1. Would deviate and show inline
    But they still want to know if it’s good accuracy

Designs

Figma

Image Image Image

Options:

  • Get location
  • Save location
  • Retry getting location

Notes

Future iterations

  • Maybe make the accuracy number larger in the dialog
@alyblenkin alyblenkin converted this from a draft issue Nov 11, 2024
@alyblenkin alyblenkin modified the milestone: Next Nov 11, 2024
@lognaturel lognaturel mentioned this issue Jan 13, 2025
@lognaturel lognaturel added this to the Next milestone Jan 28, 2025
@latin-panda latin-panda moved this from Todo to In Progress in Web Forms Feb 4, 2025
@latin-panda
Copy link
Collaborator

latin-panda commented Feb 4, 2025

Test plan

  • Geopoint is required and the value is null
    • Prevent saving the form and highlight the question as required.
  • Geopoint is disabled
    • Shows the question label and the readonly info of coordinates. It cannot change the value
    • Shows only the question label and nothing else when there aren't coordinates. It cannot change the value
  • Geopoint has a relevant criteria
    • Shows question label and option to catch location when it becomes relevant.
    • Doesn't show anything when the question is not relevant.
  • User wants to retry to get the location
    • Allows changing the question value by getting new location coordinates.
    • Allows canceling and keeping the previous value
  • Geopoint value is correct
    • The value is formatted in the correct order and not missing information: Space-separated list of latitude (decimal), longitude (decimal), altitude (decimal), and accuracy (decimal).
    • The value is null when the question isn't answered.
  • Geopoint with no parameter
    • It captures location when default value thresholds are reached: capture-accuracy's default value is 5, and warning-accuracy's default value is 100
  • Geopoint with parameter
    • Sames as Geopoint with no parameter but according to the configured parameters' value
  • Geopoint's capture-accuracy is zero
    • Keep on accessing the location until the user explicitly chooses to capture the point
    • Shows warning if accuracy reaches warning-accuracy
  • Geopoint's warning-accuracy is zero
    • Never shows warning
  • Geopoint has captured the location
    • It shows Latitude, Longitude, altitude, accuracy, time elapsed
    • Save, cancel and try again buttons works.
  • Geopoint has no permission to capture the location
    • Shows modal with basic troubleshooting steps and an ok button.
  • Geopoint UI display
    • Reacts to translation changes
    • Responsive design - should stack elements
    • It flows with other question types (similar styles: color, border, etc.)
    • Cross-browser: Chrome, Firefox, Safari, Chrome for Android, Chrome for iPhone

Sample forms for testing

1-geopoint-zero-accuracy.xlsx
1-geopoint-relevant-disabled.xlsx
1-geopoint-default-required.xlsx
1-geopoint.xlsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants