fix: update devenv to v1.15.6 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhogatemadhura
approved these changes
Oct 14, 2021
jaredallard
approved these changes
Oct 14, 2021
|
🎉 This PR is included in version 1.28.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When running e2e tests the older version of devenv image has go 1.16.2, updating to the latest devenv moves this to go 1.17.1 and can now compile and run features in go 1.17.1
Notes for your reviewer:
I was iterating on telefork until I was able to get the e2e to pass. Below is the version where it passed.
https://app.circleci.com/pipelines/github/getoutreach/telefork/321/workflows/26027e09-3e8a-4183-a680-7dbeeb155d9e/jobs/1419