Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): slim down jobs, ensure auth happens #836

Merged
merged 18 commits into from
Nov 27, 2024

Conversation

malept
Copy link
Member

@malept malept commented Nov 27, 2024

What this PR does / why we need it

  • Reduce the amount of setup in the shared/docker_* jobs by replacing setup_environment with the bare minimum setup required to authenticate to Docker image registries (via the shared/docker_auth command). This saves about 1m30s in every (successful) CircleCI run. A side effect of this was to avoid running the mage version command, which requires installing Go.
  • Use both the push and pull registry values from either the environment or the box config to determine which registries need to be authenticated.
  • Make sure that the ECR repository exists before pushing to it.

Jira ID

DT-4462

@malept malept requested a review from a team as a code owner November 27, 2024 03:48
@getoutreach-ci-2
Copy link

Link to code coverage report (posted by coverbot 🤖)

@malept malept merged commit ce121a4 into main Nov 27, 2024
5 checks passed
@malept malept deleted the malept/fix/slim-down-docker-jobs branch November 27, 2024 19:21
@getoutreach-ci-2
Copy link

🎉 This PR is included in version 2.29.0-rc.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants