Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support newer stencil modulehook framework #2

Merged
merged 5 commits into from
Apr 29, 2022

Conversation

jaredallard
Copy link
Contributor

@jaredallard jaredallard commented Apr 28, 2022

What this PR does / why we need it

This PR moves us to support the new []interface{} signature from stencil.GetModuleHook, we also enable pre-releases now and move to the new generic merge job for automatic releasing.

Jira ID

[XX-XX]

Notes for your reviewers

@jaredallard jaredallard force-pushed the jaredallard/fix/support-stencil-modulehook-changes branch from e8cdce1 to 6fc9a0d Compare April 28, 2022 03:15
@jaredallard jaredallard force-pushed the jaredallard/fix/support-stencil-modulehook-changes branch from 6fc9a0d to 30fcabf Compare April 28, 2022 20:23
@jaredallard jaredallard force-pushed the jaredallard/fix/support-stencil-modulehook-changes branch from 333bb5f to 45014fe Compare April 29, 2022 01:39
@jaredallard jaredallard force-pushed the jaredallard/fix/support-stencil-modulehook-changes branch from 4032655 to 3fd57f9 Compare April 29, 2022 01:42
@jaredallard jaredallard marked this pull request as ready for review April 29, 2022 01:55
@jaredallard jaredallard requested a review from a team April 29, 2022 01:55
Comment on lines +11 to +12
- docker-registry
- ghaccesstoken
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docs publishing requires the confluence context

@jaredallard jaredallard merged commit 9e3a68c into main Apr 29, 2022
@jaredallard jaredallard deleted the jaredallard/fix/support-stencil-modulehook-changes branch April 29, 2022 02:20
@getoutreach-ci-2
Copy link

🎉 This PR is included in version 0.1.4-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@getoutreach-ci-2
Copy link

🎉 This PR is included in version 0.1.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants