Skip to content

Commit e87efc8

Browse files
alexanderlzarikfr
authored andcommittedOct 11, 2018
fixes #2924 (#2931)
Google Spreadsheets: support for open by url
1 parent be7f601 commit e87efc8

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed
 

‎redash/query_runner/google_spreadsheets.py

+11-1
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@ def request(self, *args, **kwargs):
147147

148148

149149
class GoogleSpreadsheet(BaseQueryRunner):
150+
150151
@classmethod
151152
def annotate_query(cls):
152153
return False
@@ -190,13 +191,22 @@ def _get_spreadsheet_service(self):
190191
def test_connection(self):
191192
self._get_spreadsheet_service()
192193

194+
def is_url_key(self, key):
195+
if key.startswith('https://'):
196+
return True
197+
return False
198+
193199
def run_query(self, query, user):
194200
logger.debug("Spreadsheet is about to execute query: %s", query)
195201
key, worksheet_num = parse_query(query)
196202

197203
try:
198204
spreadsheet_service = self._get_spreadsheet_service()
199-
spreadsheet = spreadsheet_service.open_by_key(key)
205+
206+
if self.is_url_key(key):
207+
spreadsheet = spreadsheet_service.open_by_url(key)
208+
else:
209+
spreadsheet = spreadsheet_service.open_by_key(key)
200210

201211
data = parse_spreadsheet(spreadsheet, worksheet_num)
202212

0 commit comments

Comments
 (0)
Please sign in to comment.