Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long tags cause page layout issues #2829

Closed
jezdez opened this issue Sep 17, 2018 · 4 comments
Closed

Long tags cause page layout issues #2829

jezdez opened this issue Sep 17, 2018 · 4 comments
Assignees
Labels

Comments

@jezdez
Copy link
Member

jezdez commented Sep 17, 2018

Steps to Reproduce:

  • Create a long tag and add it to a query
    and
  • Create a long tag and add it to a dashboard
  • Open all dashboards page and observe the page layout
  • Open all queries page and observe the page layout

This was originally reported downstream (mozilla#476) and is also related to #2803

Expected results:

There are no page layout issues

Actual results:

The page is not correctly displayed

Notes/Issues:

Verified in FF61(Win7). Issue can be reproduced in STMO-stage
Please view this screencast:
dashboardslongtags
querieslongtags

Technical details:

  • Redash Version: 5.0beta
  • Browser/OS: Firefox 62, macOS 10.13
  • How did you install Redash: Docker
@arikfr
Copy link
Member

arikfr commented Sep 17, 2018

I think a solution for this issue and #2831 is to put a limit on the size of the tag HTML element?

@kocsmy
Copy link
Collaborator

kocsmy commented Sep 19, 2018

I was thinking about this and I do agree that we need to handle these edge cases in styling but it would also make sense to introduce a size limit (because tags should be short).

@kocsmy
Copy link
Collaborator

kocsmy commented Oct 26, 2018

PR open at #3006

@jezdez
Copy link
Member Author

jezdez commented Nov 7, 2018

Thanks @kocsmy!

@jezdez jezdez closed this as completed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants