Visualisation type map(markers) marker image missing

[laurikoobas]

Issue Summary

When using the map(markers) visualization type then the single marker image seems to be missing. It points me to this place:
https:///static/images/////node_modules/leaflet/dist/images/marker-icon-2x.png

Steps to Reproduce

1. Write this query select 24 as x, 60 as y
2. Choose Map (Markers) visualization
3. Pick x or y for latitude and longitude and observe how the browser shows a missing image icon in middle of the ocean somewhere

Technical details:

• Redash Version: latest (5.something)
• Browser/OS: Chrome (Windows)
• How did you install Redash: manually.. ?

[kravets-levko]

Hi @laurikoobas! Seems it's a setup issue (and URL to the image does not look correct as well). Please ensure that you executed npm install and npm run build commands, then check the app/dist folder:

[mrsweaters]

@kravets-levko I'm having the same issue. I'm using the legacy approach to upgrade and not the docker image. I tried running npm install and npm run build from the /opt/redash/current directory but it just broke the app. I managed to get back to where I was by running sudo bin/upgrade again.

[mrsweaters]

Other map related images don't seem to be loading either:

[arikfr]

@mrsweaters did you try using the release tar balls we distribute (available from version.redash.io)?

[mrsweaters]

I followed the instructions outlined on https://version.redash.io/ to upgrade. Which led me to https://redash.io/help/open-source/admin-guide/how-to-upgrade-legacy. I'm not sure if that is what you are asking though. Could you clarify? Thanks!

[mrsweaters]

Upgrading to 6.0 also has the same issue.

[arikfr]

You mentioned that you had to run npm install/bundle, which are not needed if you use the standard upgrade process, hence my confusion.

I did manage to reproduce this and will check this out.

Thanks.

[TomFrost]

+1 from another non-docker standard install, upgraded regularly over the course of a year with the upgrade script. Image URL is /static/images/_/_/_/_/node_modules/leaflet/dist/images/marker-icon.png

Redash Version 6.0.0+b8536 (4780bd9)

[arikfr]

Ok, the reason for this is actually obvious: in the script that packages the tar ball file we exclude node_modules:

redash/.circleci/pack

Line 9 in 26f0ce0

tar -zcv -f /tmp/artifacts/$FILENAME --exclude="optipng*" --exclude=".git*" --exclude="*.pyc" --exclude="*.pyo" --exclude="venv" --exclude="node_modules" *

(see the last --exclude flag)

We need to change this to exclude only the root node_modules folder.

[arikfr]

This should be fixed in v7 tarball. Please re-open if it reproduces.