Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the dashboard grid to React #3285

Closed
arikfr opened this issue Jan 15, 2019 · 5 comments · Fixed by #3722
Closed

Migrate the dashboard grid to React #3285

arikfr opened this issue Jan 15, 2019 · 5 comments · Fixed by #3722
Assignees
Labels
Feature: Dashboards Frontend: React Frontend codebase migration to React Frontend

Comments

@arikfr
Copy link
Member

arikfr commented Jan 15, 2019

https://github.com/STRML/react-grid-layout might be relevant here.

Part of the React migration (#3071).

Blocked by #3301.

@ranbena
Copy link
Contributor

ranbena commented Jan 15, 2019

react-grid-layout seems like best choice.

@arikfr any functionality improvements you'd like to add?
e.g Skeleton widget loading to prevent initial clunkiness (jumpy widget heights).

@arikfr
Copy link
Member Author

arikfr commented Jan 15, 2019

As with any migration, it's best if we focus on porting current functionality before doing any improvements. If there are some quick wins that can be added on the way, then sure.

Reducing the minimum "step" size could be nice, but it has implications on existing widgets, so not sure about it.

@kravets-levko
Copy link
Collaborator

Reducing the minimum "step" size could be nice, but it has implications on existing widgets, so not sure about it.

It will just require migration to update existing widgets (sizes and positions).

@ranbena
Copy link
Contributor

ranbena commented Apr 18, 2019

Closes #1775.

@arikfr
Copy link
Member Author

arikfr commented Apr 18, 2019

@ranbena I think that #1775 is more about widgets in general, like UI components. Anyway, not relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Dashboards Frontend: React Frontend codebase migration to React Frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants