[Widget Params] Bug: widget oblivious to updated static value

[ranbena]

Originally reported by @arikfr in #3334 (comment).

STR:

1. Go to widget with static parameter, click "edit parameters".
2. Change value of parameter, click "save".

Expected - Widget auto refreshes with new value.
Actual - Widget remains with previous value.

Clicking the widget refresh button updates it. Just need to make it automatic on change.

[ranbena]

@kravets-levko is this something you have time to fix?

[ranbena]

@arikfr @kravets-levko do you think this would do it? a843b92

[kravets-levko]

Indeed it will work. I'm just not sure if it solves described issue - it will refresh widget on any parameter mappings change, not only static values 🤔

[ranbena]

Indeed it will work. I'm just not sure if it solves described issue - it will refresh widget on any parameter mappings change, not only static values 🤔

Makes sense anyway, no? If any param changed, refresh visualization.

[kravets-levko]

Makes sense anyway, no?

Probably yes 🙂

[kravets-levko]

@arikfr WDYT?

[arikfr]

I think it makes sense -- like the case where you change a mapping from one dashboard param to another.

So as long as it runs when mapping changed, I'm good with this.

[ranbena]

In this pr it refreshes on save button click. Which means, also param label renaming. Would you like to filter that case out?

Is refresh such an expensive action that we'd rather avoid any needless calls to it?

[arikfr]

Is refresh such an expensive action that we'd rather avoid any needless calls to it?

Sometimes it is, sometimes it isn't...

If it's easy to call it only when really needed, let's do it. Otherwise, let's fix the bug.

[susodapop]

In this pr it refreshes on save button click.

In my experience this could be a real dealbreaker for trying out the functionality. Some of my dashboards can take north of a minute to update. It feels weird to make changes to the title of a parameter and have it refresh the relevant widgets. Refresh should only happen when absolutely necessary IMO.

[ranbena]

Made it so only parameter value changes trigger an automatic refresh.
Title changes won't, even param type change won't.
#3445