Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace toastr with Ant component #3547

Closed
3 tasks
arikfr opened this issue Mar 7, 2019 · 2 comments
Closed
3 tasks

Replace toastr with Ant component #3547

arikfr opened this issue Mar 7, 2019 · 2 comments
Assignees
Labels
Frontend: React Frontend codebase migration to React Frontend

Comments

@arikfr
Copy link
Member

arikfr commented Mar 7, 2019

  • Pick Ant component to use (<Notification> or <Message>, maybe both?).
  • Replace calls to toastr with one of the above.
  • Remove angular-toastr from dependencies.
@arikfr arikfr added Frontend Frontend: React Frontend codebase migration to React labels Mar 7, 2019
@arikfr arikfr mentioned this issue Mar 7, 2019
@kravets-levko
Copy link
Collaborator

I think <Notification> is a direct replacement for angular-toastr. Also, IMO it's less annoying - Message is always shown on middle-top part of screen and therefore attracts more attention (especially when there are 2-3 messages at the same time - sometimes it happens in Redash).

@arikfr
Copy link
Member Author

arikfr commented Mar 7, 2019

It seems that Notification is supposed to be used with lighter messages like "Query Saved" while Notification is for longer stuff, like -- "Test Connection failed, here's the details: ...".

But if Notification "works" with short content as well, then probably best to have only one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend: React Frontend codebase migration to React Frontend
Projects
None yet
Development

No branches or pull requests

3 participants