Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Esc key should cancel parameter edits #3802

Open
arikfr opened this issue May 15, 2019 · 1 comment
Open

Esc key should cancel parameter edits #3802

arikfr opened this issue May 15, 2019 · 1 comment
Assignees
@gabrieldutra
Labels
Feature: Parameters Frontend UX
Milestone
Next

Comments

@arikfr
Copy link
Member

arikfr commented May 15, 2019

Following #3737, when the user hits Esc when editing a parameter, it should:

  1. For <Input> parameters, revert to previous value (and hide Apply button).
  2. For dropdowns/dates, close the edit dialog (and restore previous value if relevant).
@arikfr arikfr added this to the Next milestone May 15, 2019
@ranbena
Copy link
Contributor

ranbena commented May 15, 2019

For dropdowns/dates, close the edit dialog (and restore previous value if relevant).

I'm not sure non-apply-button inputs (like dropdowns and dates) mandate an esc behavior.

  1. Input value change immediately executes query so reverting would have to cancel or re-run.
  2. I don't think it's an expected behavior by users.
  3. I reckon it would complicate the code.

@weekly-digest weekly-digest bot mentioned this issue May 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrieldutra gabrieldutra

Labels
Feature: Parameters Frontend UX
Projects
None yet
Milestone
Next
Development

No branches or pull requests
3 participants
@arikfr @ranbena @gabrieldutra