You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Comparing version 7 with current master, it's apparent that autoheight table visualization widgets are higher now by 1 row.
Version 7
Master branch
How come?
#3830 added a 10px bottom padding to tables but with -10px margin to compensate*.
Thing is, autoheight is calculated with getBoundingClientRect() which understandably includes padding but not margin, thus adding 10px to the visualization height - resulting in an additional grid row.
* Mac only - therefore not detected by e2e tests 😓
The text was updated successfully, but these errors were encountered:
I'm thinking we should revert #3830 - it's a workaround for a browser bug (btw, happens to me on GH code blocks as well..) and I feel no obligation to keep it.
@ranbena while I agree with your sentiment towards #3830, the problem is that sometimes it really blocks the content and makes it impossible to read. I couldn't reliably reproduce it and in most cases it was fine, but I can see how frustrating it can be when it does happen.
Issue Summary
Comparing version 7 with current master, it's apparent that autoheight table visualization widgets are higher now by 1 row.
How come?
#3830 added a 10px bottom padding to tables but with -10px margin to compensate*.
Thing is, autoheight is calculated with
getBoundingClientRect()
which understandably includes padding but not margin, thus adding 10px to the visualization height - resulting in an additional grid row.* Mac only - therefore not detected by e2e tests 😓
The text was updated successfully, but these errors were encountered: