Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoheight widgets miscalculating height #3859

Closed
ranbena opened this issue May 31, 2019 · 2 comments · Fixed by #3875
Closed

Autoheight widgets miscalculating height #3859

ranbena opened this issue May 31, 2019 · 2 comments · Fixed by #3875
Assignees
Labels

Comments

@ranbena
Copy link
Contributor

ranbena commented May 31, 2019

Issue Summary

Comparing version 7 with current master, it's apparent that autoheight table visualization widgets are higher now by 1 row.

Version 7 Master branch
Screen Shot 2019-05-30 at 19 22 17 Screen Shot 2019-05-30 at 19 22 02

How come?

#3830 added a 10px bottom padding to tables but with -10px margin to compensate*.
Thing is, autoheight is calculated with getBoundingClientRect() which understandably includes padding but not margin, thus adding 10px to the visualization height - resulting in an additional grid row.

* Mac only - therefore not detected by e2e tests 😓

@ranbena ranbena self-assigned this May 31, 2019
@ranbena ranbena added the Bug label May 31, 2019
@ranbena
Copy link
Contributor Author

ranbena commented May 31, 2019

I'm thinking we should revert #3830 - it's a workaround for a browser bug (btw, happens to me on GH code blocks as well..) and I feel no obligation to keep it.

@arikfr @kravets-levko @gabrieldutra any better ideas?

@arikfr
Copy link
Member

arikfr commented May 31, 2019

@ranbena while I agree with your sentiment towards #3830, the problem is that sometimes it really blocks the content and makes it impossible to read. I couldn't reliably reproduce it and in most cases it was fine, but I can see how frustrating it can be when it does happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants