Dashboard filters disappear after changing dashboard parameter values

[gabrieldutra]

Issue Summary

My guess is that this was introduced with #3804

Steps to Reproduce

1. Create a dashboard with a widget containing a filter and another widget containing a parameter (or use an existing one);
2. Map the Widget Parameter to be a Dashboard Parameter and enable Dashboard level filters;
3. Change the Parameter value and verify the filter options disappear

Technical details:

• Redash Version: Latest
• Browser/OS: --
• How did you install Redash: --

[gabrieldutra]

Code related to the issue:

redash/client/app/pages/dashboards/dashboard.js

Lines 159 to 167 in a8af968

	const queryResultPromises = _.compact(affectedWidgets.map(widget => this.loadWidget(widget, forceRefresh)));
	return $q.all(queryResultPromises).then((queryResults) => {
	this.filters = collectDashboardFilters(dashboard, queryResults, $location.search());
	this.filtersOnChange = (allFilters) => {
	this.filters = allFilters;
	$scope.$applyAsync();
	};
	});

This seems to be easily solved by using the code below for the queryResults instead of the Promise results:

const queryResults = compact(map(dashboard.widgets, widget => widget.getQueryResult()));

Though, I'm also considering to refactor that part of the code along with Dashboard & Public Dashboard migration, e.g: it makes sense for the Refreshing Code to be separated from the Collect Filters Part.

Depending on when this needs to be fixed, we can go with the quick solution.

[ranbena]

it makes sense for the Refreshing Code to be separated from the Collect Filters Part.

I favor this approach.