Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query page title isn't shown on mobile in some scenarios #4330

Closed
arikfr opened this issue Nov 3, 2019 · 3 comments · Fixed by #4337
Closed

Query page title isn't shown on mobile in some scenarios #4330

arikfr opened this issue Nov 3, 2019 · 3 comments · Fixed by #4337
Assignees

Comments

@arikfr
Copy link
Member

arikfr commented Nov 3, 2019

When opening a query page from the queries list, its title is hidden by the navbar.

@gabrieldutra
Copy link
Member

While checking this issue I noticed that it couldn't be reproduced through Chrome Devtools, so I debugged it using a Remote Device:

Screenshot from 2019-11-04 14-39-58
(Note that the whole margin is put below the Mobile Chrome navigation options)

My guess from my tests is that what specifically causes the issue is changing angular route from an scrolled page to the query page, so it keeps the scrolling information .Also it seems to need the Mobile navigation options for the issue to happen and I don't understand 100% why that is, but I'm running tests from #4337.

@gabrieldutra
Copy link
Member

The thing with the address bar is that the vh unit considers it as "hidden", so when you have 100vh you'll have a hidden portion when the address bar shows up.

Adding autoscroll to the ng-view partially solves (available here) the issue and makes the behavior similar to what it was previous to the fixed navbar: the "hidden portion" comes back to be the bottom controls on the Query Page (# of rows returned, execute button).

@arikfr wdyt of using that until the React Migration for the query page as a few mobile updates can be done along with it?

@arikfr
Copy link
Member Author

arikfr commented Nov 19, 2019

@arikfr wdyt of using that until the React Migration for the query page as a few mobile updates can be done along with it?

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants